Skip to content

🐛 Fix eks awsmanagedcontrolplane finalizer permission #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

🐛 Fix eks awsmanagedcontrolplane finalizer permission #5668

merged 1 commit into from
Sep 18, 2025

Conversation

serngawy
Copy link
Contributor

@serngawy serngawy commented Sep 17, 2025 •
edited
Loading

The EKS is provisioned successfully. But the cluster kubeconfig is missing in the cluster namespace.
find a error condition in AWSManagedControlPlane

message: 'failed reconciling kubeconfig: creating kubeconfig secret: failed to create kubeconfig secret: secrets "capi-eks-cluster-kubeconfig" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can''t set finalizers on: , <nil>' reason: EKSControlPlaneReconciliationFailed

the error message in capa-manager-contrller

E0916 13:39:10.681999       1 controller.go:316] "Reconciler error" err="failed to reconcile control plane for AWSManagedControlPlane capi-eks-cluster/capi-eks-cluster-control-plane: failed reconciling kubeconfig: creating kubeconfig secret: failed to create kubeconfig secret: secrets \"capi-eks-cluster-kubeconfig\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>" controller="awsmanagedcontrolplane" controllerGroup="controlplane.cluster.x-k8s.io" controllerKind="AWSManagedControlPlane" AWSManagedControlPlane="capi-eks-cluster/capi-eks-cluster-control-plane" namespace="capi-eks-cluster" name="capi-eks-cluster-control-plane" reconcileID="3f34eda8-ba9b-4de9-9b7c-81372e4fcffd"

after add awsmanagedcontrolplanes/finalizer update permission in the clusterrole capa-manager-role, it works.

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

fix awsmanagedcontrolplanes/finalizer permission

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 17, 2025
@serngawy
Copy link
Contributor Author

@richardcase

damdo
damdo reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @richardcase @nrb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c8decb9c04b7d334ecff51aed50791196af268f

@richardcase
Copy link
Member

/approve

@richardcase
Copy link
Member

/cherry-pick release-2.9

@k8s-infra-cherrypick-robot
Copy link

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3456ed8 into kubernetes-sigs:main Sep 18, 2025
26 checks passed
@k8s-infra-cherrypick-robot
Copy link

@richardcase: new pull request created: #5669

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@luthermonson luthermonson Awaiting requested review from luthermonson

@nrb nrb Awaiting requested review from nrb

Assignees

@richardcase richardcase

@nrb nrb

@damdo damdo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serngawy @k8s-ci-robot @richardcase @k8s-infra-cherrypick-robot @damdo @nrb